Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate chain and io transaction in DB storage #738

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Dec 2, 2022

Description

For now IO transaction are used only for updating the inputs of a transaction. Therefor we don't want to update anything in the ChainIndex like the last address.
So the idea is to create 2 storage folder, one for io tx and one for chain tx, and do not update ChainIndex while writing an io transaction

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit tests
  • Start 5 node with sharding properties updated
  • Create some transactions, nodes should store io transaction in "io" folder
  • Stop and restart a node, it should update the account mem table properly

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working DB Involve database replication labels Dec 2, 2022
@Neylix Neylix force-pushed the Separate-chain-and-io-transaction branch from 47e00c9 to 63546ca Compare December 2, 2022 11:33
@samuelmanzanera samuelmanzanera merged commit 64ba6b3 into archethic-foundation:develop Dec 2, 2022
@Neylix Neylix deleted the Separate-chain-and-io-transaction branch December 5, 2022 10:22
tenmoves pushed a commit to tenmoves/archethic-node that referenced this pull request Dec 6, 2022
…#738)

* Write IO transaction in a new folder to separate logic
* Load IO transactions on node start
* Fix contract loader on start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DB Involve database replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants